Skip to content

Fix sidecar.istio.io/inject: false use label instead of annotation#4420

Open
SecretSun wants to merge 5 commits intofluid-cloudnative:masterfrom
SecretSun:master
Open

Fix sidecar.istio.io/inject: false use label instead of annotation#4420
SecretSun wants to merge 5 commits intofluid-cloudnative:masterfrom
SecretSun:master

Conversation

@SecretSun
Copy link

@SecretSun SecretSun commented Nov 28, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #4418

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Nov 28, 2024

Hi @SecretSun. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheyang
cheyang requested changes Nov 29, 2024
View reviewed changes
@cheyang
Copy link
Collaborator

cheyang commented Nov 29, 2024

@SecretSun please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/4420/checks?check_run_id=33663774331 .

@SecretSun
Update statefulset.yaml
8590913 
Signed-off-by: Secret.Sun <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] sidecar.istio.io/inject: false use label instead of annotation

2 participants

@SecretSun @cheyang